Grant Henke has submitted this change and it was merged. (
http://gerrit.cloudera.org:8080/10077 )
Change subject: [Java] Use Yetus annotations in place of @VisibleForTesting
......................................................................
[Java] Use Yetus annotations in place of @VisibleForTesting
We use yetus for marking our intended InterfaceAudience.
This patch replaces Guava’s @VisibleForTesting with
@InterfaceAudience.LimitedPrivate("Test”).
kudu-hive is an exception to the rule because it can not
have any dependencies that are not provided by the
hive-metastore. This limitation is noted in the kudu-hive
build files.
I also elimated an uneccesary usage of ImmutableList
and Lists while making this change. Scala has
straightforward syntax for making lists without Guava.
The primary reason for this change is to use
Yetus as the single annotation library for defining
InterfaceAudience, but this has the added benefit
of eliminating any Guava use in kudu-spark,
kudu-spark-tools which didn’t
have Gauva marked as a dependency.
Change-Id: Ic0d8845e8cbbf5ea81345c46c5487121d1098f91
Reviewed-on: http://gerrit.cloudera.org:8080/10077
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <a...@cloudera.com>
Reviewed-by: Dan Burkert <danburk...@apache.org>
---
M java/kudu-client-tools/build.gradle
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Batch.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ConnectToCluster.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Connection.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ConnectionCache.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduClient.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduPredicate.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduRpc.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduScanToken.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduScanner.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Negotiator.java
M java/kudu-client/src/main/java/org/apache/kudu/client/RpcProxy.java
M java/kudu-client/src/main/java/org/apache/kudu/client/SecurityContext.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Status.java
M java/kudu-client/src/main/java/org/apache/kudu/client/TableLocationsCache.java
M java/kudu-client/src/main/java/org/apache/kudu/util/ByteVec.java
M java/kudu-flume-sink/src/main/java/org/apache/kudu/flume/sink/KuduSink.java
M java/kudu-spark-tools/build.gradle
M java/kudu-spark-tools/pom.xml
M
java/kudu-spark-tools/src/main/scala/org/apache/kudu/spark/tools/ImportExportFiles.scala
M
java/kudu-spark-tools/src/main/scala/org/apache/kudu/spark/tools/IntegrationTestBigLinkedList.scala
M
java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/TestContext.scala
25 files changed, 51 insertions(+), 64 deletions(-)
Approvals:
Kudu Jenkins: Verified
Adar Dembo: Looks good to me, but someone else must approve
Dan Burkert: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/10077
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic0d8845e8cbbf5ea81345c46c5487121d1098f91
Gerrit-Change-Number: 10077
Gerrit-PatchSet: 8
Gerrit-Owner: Grant Henke <granthe...@apache.org>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <danburk...@apache.org>
Gerrit-Reviewer: Grant Henke <granthe...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
