Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10131 )
Change subject: build-support: add a nicer logger to python scripts ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/10131/2/build-support/kudu_util.py File build-support/kudu_util.py: http://gerrit.cloudera.org:8080/#/c/10131/2/build-support/kudu_util.py@49 PS2, Line 49: ColorFilter() > Should this depend on sys.stdout.isatty() ? In other words, do we want ext The 'Colors' constants already turn into empty strings on non-TTY output -- To view, visit http://gerrit.cloudera.org:8080/10131 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic648fadfbb11eb3e0a8f137ae3f3143e52149101 Gerrit-Change-Number: 10131 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Fri, 20 Apr 2018 05:17:14 +0000 Gerrit-HasComments: Yes
