Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/10115 )
Change subject: KUDU-2368 Configure num_reactors in client ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/10115/1/src/kudu/client/client.h File src/kudu/client/client.h: http://gerrit.cloudera.org:8080/#/c/10115/1/src/kudu/client/client.h@249 PS1, Line 249: @brief Set the number of r > Since this is a public API we should probably explain further what this mea I'm not quite sure about how this should be set, but I expanded the text on what I know. Is this enough or should anything else be added? http://gerrit.cloudera.org:8080/#/c/10115/1/src/kudu/client/client.h@251 PS1, Line 251: The reactor threads are used fo > Yea I think it's better to be vague here and say that if not specified, the Done http://gerrit.cloudera.org:8080/#/c/10115/1/src/kudu/client/client_builder-internal.h File src/kudu/client/client_builder-internal.h: http://gerrit.cloudera.org:8080/#/c/10115/1/src/kudu/client/client_builder-internal.h@42 PS1, Line 42: :string authn > yea, seems this should be optional<> and then only call the setter on the m Done -- To view, visit http://gerrit.cloudera.org:8080/10115 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8320d7d664b8006111e7316643f58b4e32c5081f Gerrit-Change-Number: 10115 Gerrit-PatchSet: 2 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Mon, 23 Apr 2018 16:15:45 +0000 Gerrit-HasComments: Yes
