Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10115 )
Change subject: KUDU-2368 Configure num_reactors in client ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/10115/1/src/kudu/client/client.h File src/kudu/client/client.h: http://gerrit.cloudera.org:8080/#/c/10115/1/src/kudu/client/client.h@249 PS1, Line 249: Set the number of reactors > Set the number of reactors for the RPC messenger. Since this is a public API we should probably explain further what this means, how someone might want to set it, etc. http://gerrit.cloudera.org:8080/#/c/10115/1/src/kudu/client/client.h@251 PS1, Line 251: If not provided, defaults to 4. > Another approach might be just using the messenger's default number of reac Yea I think it's better to be vague here and say that if not specified, the implementation will choose a value. Currently the choosing is hard-coded 4 but in the future we may choose the number of CPUs or somesuch http://gerrit.cloudera.org:8080/#/c/10115/1/src/kudu/client/client_builder-internal.h File src/kudu/client/client_builder-internal.h: http://gerrit.cloudera.org:8080/#/c/10115/1/src/kudu/client/client_builder-internal.h@42 PS1, Line 42: num_reactors_ > Where is the default value for this num_reactors_ is assigned? Maybe, it s yea, seems this should be optional<> and then only call the setter on the messenger if necessary -- To view, visit http://gerrit.cloudera.org:8080/10115 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8320d7d664b8006111e7316643f58b4e32c5081f Gerrit-Change-Number: 10115 Gerrit-PatchSet: 1 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Fri, 20 Apr 2018 01:10:59 +0000 Gerrit-HasComments: Yes
