Todd Lipcon has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/2942 )

Change subject: rpc: cache call deadline in InboundCall
......................................................................


Patch Set 5: Verified+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/2942/4/src/kudu/rpc/inbound_call.h
File src/kudu/rpc/inbound_call.h:

http://gerrit.cloudera.org:8080/#/c/2942/4/src/kudu/rpc/inbound_call.h@250
PS4, Line 250:   // after serialization of the protobuf. See rpc/rpc_sidecar.h 
for more info.
> Nit: document this? Normally I wouldn't really care, but virtually every ot
Done



--
To view, visit http://gerrit.cloudera.org:8080/2942
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I72138b4dcee6db105bbf9499961c4c1e8c26bd3f
Gerrit-Change-Number: 2942
Gerrit-PatchSet: 5
Gerrit-Owner: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Binglin Chang <[email protected]>
Gerrit-Reviewer: Henry Robinson <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <[email protected]>
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-Comment-Date: Mon, 23 Apr 2018 22:41:17 +0000
Gerrit-HasComments: Yes

Reply via email to