Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10163 )
Change subject: WIP Workaround KUDU-2233 when the history was already deleted ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/10163/1/src/kudu/tablet/compaction.cc File src/kudu/tablet/compaction.cc: http://gerrit.cloudera.org:8080/#/c/10163/1/src/kudu/tablet/compaction.cc@65 PS1, Line 65: loosing nit: losing http://gerrit.cloudera.org:8080/#/c/10163/1/src/kudu/tablet/compaction.cc@798 PS1, Line 798: pv_delete_redo != nullptr || : pv_delete_redo->changelist().is_delete() || : pv_delete_redo->next() == nullptr) shouldn't all of these conditions be negated? -- To view, visit http://gerrit.cloudera.org:8080/10163 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I90b78d27f0b6776bb004d9c7690980ac305628bb Gerrit-Change-Number: 10163 Gerrit-PatchSet: 1 Gerrit-Owner: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Mon, 23 Apr 2018 22:43:19 +0000 Gerrit-HasComments: Yes
