Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/6696 )
Change subject: cache: add a benchmark ...................................................................... Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/6696/1/src/kudu/util/cache-bench.cc File src/kudu/util/cache-bench.cc: http://gerrit.cloudera.org:8080/#/c/6696/1/src/kudu/util/cache-bench.cc@95 PS1, Line 95: > nit: extra line Done http://gerrit.cloudera.org:8080/#/c/6696/1/src/kudu/util/cache-bench.cc@97 PS1, Line 97: TEST_P(CacheBench, RunBench) { > would it be interesting to also measure cache churn? do you mean the eviction rate? I think since we are doing one insert for every miss, and the elements are all the same size, the miss rate and eviction rate are the same, right? http://gerrit.cloudera.org:8080/#/c/6696/1/src/kudu/util/cache-bench.cc@98 PS1, Line 98: 16; > make this a flag? Done http://gerrit.cloudera.org:8080/#/c/6696/1/src/kudu/util/cache-bench.cc@99 PS1, Line 99: const int kSecondsToRun = AllowSlowTests() ? 10 : 1; > Can you then document more what this test is about? I added a warmup phase so it should converge faster. I still made it configurable since most of our benchmarks are configurable and it can help to get better samples for 'perf record', etc -- To view, visit http://gerrit.cloudera.org:8080/6696 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I156d170c20913a17e4f94b40879409f4798023ab Gerrit-Change-Number: 6696 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Wed, 25 Apr 2018 20:28:13 +0000 Gerrit-HasComments: Yes
