Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/4425 )
Change subject: java: enable error-prone for java builds ...................................................................... Patch Set 3: (3 comments) As for error-prone vs spotbugs, I think they are likely complementary with a different set of checks. I personally like that error-prone produces its output as warnings in the normal compile output in the normal flow of development http://gerrit.cloudera.org:8080/#/c/4425/3/java/build.gradle File java/build.gradle: http://gerrit.cloudera.org:8080/#/c/4425/3/java/build.gradle@24 PS3, Line 24: id 'net.ltgt.errorprone' version '0.0.13' apply false > I have been putting all of these static analysis checks into quality.gradle unfortunately I couldn't move the 'plugins' definition anywhere but here. It has to be the first thing in the build file apparently http://gerrit.cloudera.org:8080/#/c/4425/3/java/build.gradle@48 PS3, Line 48: apply plugin: 'java' > Any reason you changed this to single quotes? mistake, reverted http://gerrit.cloudera.org:8080/#/c/4425/3/java/build.gradle@51 PS3, Line 51: apply from: "$rootDir/gradle/errorprone.gradle" > Did you add this file? I have been putting all of these static analysis che moved the contents to quality.gradle -- To view, visit http://gerrit.cloudera.org:8080/4425 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iebafbb307904875490426dd699ab1f55e21d284d Gerrit-Change-Number: 4425 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Wed, 25 Apr 2018 22:06:24 +0000 Gerrit-HasComments: Yes
