David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/6597 )
Change subject: cache: reduce contention on MemTracker::Release and Consume ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/6597/4/src/kudu/cfile/block_cache-test.cc File src/kudu/cfile/block_cache-test.cc: http://gerrit.cloudera.org:8080/#/c/6597/4/src/kudu/cfile/block_cache-test.cc@40 PS4, Line 40: // Disable approximate tracking of cache memory. nit: state why or remove http://gerrit.cloudera.org:8080/#/c/6597/4/src/kudu/util/cache-test.cc File src/kudu/util/cache-test.cc: http://gerrit.cloudera.org:8080/#/c/6597/4/src/kudu/util/cache-test.cc@75 PS4, Line 75: // Disable approximate tracking of cache memory. same -- To view, visit http://gerrit.cloudera.org:8080/6597 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic3bd24a452761b06611215f4831ef02238ba14bc Gerrit-Change-Number: 6597 Gerrit-PatchSet: 4 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Thu, 26 Apr 2018 20:05:54 +0000 Gerrit-HasComments: Yes
