Hello David Ribeiro Alves, Kudu Jenkins, Andrew Wong, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6597
to look at the new patch set (#5).
Change subject: cache: reduce contention on MemTracker::Release and Consume
......................................................................
cache: reduce contention on MemTracker::Release and Consume
In an old benchmark about a year ago, this improved YCSB load throughput
from ~450k ops/sec to ~570k. For the newly-added cache-bench, this
improves performance substantially (16x) for the scenario with high churn:
Before:
[ RUN ] Patterns/CacheBench.RunBench/3
I0425 13:59:17.307648 95430 cache-bench.cc:176] Warming up...
I0425 13:59:18.308992 95430 cache-bench.cc:179] Running benchmark...
I0425 13:59:19.313868 95430 cache-bench.cc:187] UNIFORM ratio=3.00x
n_unique=786432: 2.48M lookups/sec
I0425 13:59:19.313891 95430 cache-bench.cc:188] UNIFORM ratio=3.00x
n_unique=786432: 33.3% hit rate
[ OK ] Patterns/CacheBench.RunBench/3 (2192 ms)
After:
[ RUN ] Patterns/CacheBench.RunBench/3
I0425 13:57:40.581399 94314 cache-bench.cc:176] Warming up...
I0425 13:57:41.582798 94314 cache-bench.cc:179] Running benchmark...
I0425 13:57:42.583904 94314 cache-bench.cc:187] UNIFORM ratio=3.00x
n_unique=786432: 39.53M lookups/sec
I0425 13:57:42.583930 94314 cache-bench.cc:188] UNIFORM ratio=3.00x
n_unique=786432: 33.3% hit rate
[ OK ] Patterns/CacheBench.RunBench/3 (2055 ms)
Change-Id: Ic3bd24a452761b06611215f4831ef02238ba14bc
---
M src/kudu/cfile/block_cache-test.cc
M src/kudu/util/cache-test.cc
M src/kudu/util/cache.cc
3 files changed, 65 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/97/6597/5
--
To view, visit http://gerrit.cloudera.org:8080/6597
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic3bd24a452761b06611215f4831ef02238ba14bc
Gerrit-Change-Number: 6597
Gerrit-PatchSet: 5
Gerrit-Owner: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: David Ribeiro Alves <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <[email protected]>
