Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8279 )
Change subject: rpc: add experimental rpc_reuseport flag ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/8279/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/8279/3//COMMIT_MSG@11 PS3, Line 11: except RHEL 6.4 and below. As we discussed, could you run an el6.6 binary on an el6.4 VM and see what the behavior is? Does setsockopt() fail? Does it no-op? What's the effect on our unit tests and/or minicluster CLI? http://gerrit.cloudera.org:8080/#/c/8279/3/src/kudu/rpc/messenger.h File src/kudu/rpc/messenger.h: http://gerrit.cloudera.org:8080/#/c/8279/3/src/kudu/rpc/messenger.h@166 PS3, Line 166: SO_REUSEADDR SO_REUSEPORT http://gerrit.cloudera.org:8080/#/c/8279/3/src/kudu/rpc/messenger.cc File src/kudu/rpc/messenger.cc: http://gerrit.cloudera.org:8080/#/c/8279/3/src/kudu/rpc/messenger.cc@182 PS3, Line 182: reuseport_ = true; reuseport_ needs a default value. http://gerrit.cloudera.org:8080/#/c/8279/3/src/kudu/util/net/socket.cc File src/kudu/util/net/socket.cc: http://gerrit.cloudera.org:8080/#/c/8279/3/src/kudu/util/net/socket.cc@263 PS3, Line 263: Status Socket::SetReusePort(bool flag) { Seems like a fair amount of code could be consolidated if there was a single setsockopt() helper function that dealt with errno and generated a reasonable Status on failure. -- To view, visit http://gerrit.cloudera.org:8080/8279 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5d8ce9faa646fa2be554f5cfdf8b6ed0c48b496e Gerrit-Change-Number: 8279 Gerrit-PatchSet: 3 Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Mon, 30 Apr 2018 18:14:56 +0000 Gerrit-HasComments: Yes
