Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8279 )
Change subject: rpc: add experimental rpc_reuseport flag ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/8279/5/src/kudu/rpc/messenger.cc File src/kudu/rpc/messenger.cc: http://gerrit.cloudera.org:8080/#/c/8279/5/src/kudu/rpc/messenger.cc@320 PS5, Line 320: if (reuseport_) { : RETURN_NOT_OK(sock.SetReusePort(true)); : } I didn't come up with the question in the previous review round, but just in case: why not just RETURN_NOT_OK(sock.SetResultPort(false)) ? Or the idea is not to touch the default setting for the socket in 6.4 and earlier, avoiding errors? -- To view, visit http://gerrit.cloudera.org:8080/8279 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5d8ce9faa646fa2be554f5cfdf8b6ed0c48b496e Gerrit-Change-Number: 8279 Gerrit-PatchSet: 5 Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Tue, 01 May 2018 23:56:49 +0000 Gerrit-HasComments: Yes
