Todd Lipcon has submitted this change and it was merged. (
http://gerrit.cloudera.org:8080/10305 )
Change subject: bitmap-test: fix dangling-else warnings
......................................................................
bitmap-test: fix dangling-else warnings
This squelches the following two warnings:
[396/750] Building CXX object
src/kudu/util/CMakeFiles/bitmap-test.dir/bitmap-test.cc.o
../../src/kudu/util/bitmap-test.cc: In member function ‘virtual void
kudu::TestBitMap_TestFindBit_Test::TestBody()’:
../../src/kudu/util/bitmap-test.cc:187:10: warning: suggest explicit braces
to avoid ambiguous ‘else’ [-Wdangling-else]
if (expect_set_found) ASSERT_EQ(expected_set_idx, idx);
^
../../src/kudu/util/bitmap-test.cc:194:10: warning: suggest explicit braces
to avoid ambiguous ‘else’ [-Wdangling-else]
if (expect_zero_found) ASSERT_EQ(expected_zero_idx, idx);
^
Change-Id: I0cf567b69c39958acb0c6fc7aa110d38f7b718ef
Reviewed-on: http://gerrit.cloudera.org:8080/10305
Reviewed-by: Alexey Serbin <[email protected]>
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon <[email protected]>
---
M src/kudu/util/bitmap-test.cc
1 file changed, 6 insertions(+), 2 deletions(-)
Approvals:
Alexey Serbin: Looks good to me, approved
Kudu Jenkins: Verified
Todd Lipcon: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/10305
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I0cf567b69c39958acb0c6fc7aa110d38f7b718ef
Gerrit-Change-Number: 10305
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <[email protected]>
