Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10321 )
Change subject: KUDU-2403: Fix FakeDNS to work in Java 9+ ...................................................................... Patch Set 4: (5 comments) http://gerrit.cloudera.org:8080/#/c/10321/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10321/4//COMMIT_MSG@11 PS4, Line 11: implimentation implementation http://gerrit.cloudera.org:8080/#/c/10321/4//COMMIT_MSG@14 PS4, Line 14: implimentation same http://gerrit.cloudera.org:8080/#/c/10321/4//COMMIT_MSG@17 PS4, Line 17: NamService NameService http://gerrit.cloudera.org:8080/#/c/10321/4//COMMIT_MSG@19 PS4, Line 19: Implimentation same http://gerrit.cloudera.org:8080/#/c/10321/4/java/gradle/tests.gradle File java/gradle/tests.gradle: http://gerrit.cloudera.org:8080/#/c/10321/4/java/gradle/tests.gradle@39 PS4, Line 39: if (JavaVersion.current().isJava9Compatible()) { Could you reformat this a bit to reduce the duplication? Like, maybe a list of module/packages that is iterated over? -- To view, visit http://gerrit.cloudera.org:8080/10321 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I319f42b6b878531325d6a48ce6ccdcc9b40fe2bc Gerrit-Change-Number: 10321 Gerrit-PatchSet: 4 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Mon, 07 May 2018 15:47:49 +0000 Gerrit-HasComments: Yes
