Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10321 )
Change subject: KUDU-2403: Fix FakeDNS to work in Java 9+ ...................................................................... Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/10321/7/java/kudu-client/src/test/java/org/apache/kudu/client/FakeDNS.java File java/kudu-client/src/test/java/org/apache/kudu/client/FakeDNS.java: http://gerrit.cloudera.org:8080/#/c/10321/7/java/kudu-client/src/test/java/org/apache/kudu/client/FakeDNS.java@145 PS7, Line 145: } catch (Exception e) { : throw new UnknownHostException(e.getMessage()); wouldn't 'e' usually be an InvocationTargetException here, and then we would want to do something like: Throwables.propagateIfPossible(e.getCause(), UnknownHostException.class); throw new AssertionError("unexpected reflection issue", e); http://gerrit.cloudera.org:8080/#/c/10321/7/java/kudu-client/src/test/java/org/apache/kudu/client/FakeDNS.java@170 PS7, Line 170: throw new UnknownHostException(e.getMessage()); same -- To view, visit http://gerrit.cloudera.org:8080/10321 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I319f42b6b878531325d6a48ce6ccdcc9b40fe2bc Gerrit-Change-Number: 10321 Gerrit-PatchSet: 7 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Mon, 07 May 2018 17:23:56 +0000 Gerrit-HasComments: Yes
