Hello Alexey Serbin, Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/10341
to review the following change.
Change subject: KUDU-2433. Don't try to symbolize a nullptr
......................................................................
KUDU-2433. Don't try to symbolize a nullptr
Don't try to symbolize a nullptr when walking the stack. Even though a
null pc should be impossible, it might occur in cases where the stack
has been corrupted. Even though all bets are off in that case, if such
an error were to occur in a UBSAN-enabled build, we don't want to mask
the error while symbolizing a stack trace by crashing with a UBSAN
exception due to subtracting 1 from a null ptr, like what apparently
happened in KUDU-2433.
Change-Id: I77d03c1e1dc2fa8e3ec9a4c48895b44f55f457dc
---
M src/kudu/util/debug-util.cc
1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/41/10341/1
--
To view, visit http://gerrit.cloudera.org:8080/10341
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I77d03c1e1dc2fa8e3ec9a4c48895b44f55f457dc
Gerrit-Change-Number: 10341
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
