Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10341 )
Change subject: KUDU-2433. Don't try to symbolize a nullptr ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/10341/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10341/1//COMMIT_MSG@11 PS1, Line 11: Even though all bets are off in that case > per comment elsewhere, I think we sometimes get 00000000000 on the stack wh Fixed, thanks for the good alternative explanation http://gerrit.cloudera.org:8080/#/c/10341/1/src/kudu/util/debug-util.cc File src/kudu/util/debug-util.cc: http://gerrit.cloudera.org:8080/#/c/10341/1/src/kudu/util/debug-util.cc@700 PS1, Line 700: UB > I think better to say "undefined behavior" instead of abbreviating. Done http://gerrit.cloudera.org:8080/#/c/10341/1/src/kudu/util/debug-util.cc@701 PS1, Line 701: corruption > I think even without "corruption" per se, you can get 0 on the stack when b Done -- To view, visit http://gerrit.cloudera.org:8080/10341 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I77d03c1e1dc2fa8e3ec9a4c48895b44f55f457dc Gerrit-Change-Number: 10341 Gerrit-PatchSet: 1 Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Tue, 08 May 2018 16:38:48 +0000 Gerrit-HasComments: Yes
