Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10337 )
Change subject: Add a table renaming tool ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/10337/1/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/10337/1/src/kudu/tools/kudu-tool-test.cc@1847 PS1, Line 1847: workload.Start(); : workload.StopAndJoin(); nit: do we need to write any data? http://gerrit.cloudera.org:8080/#/c/10337/1/src/kudu/tools/kudu-tool-test.cc@1850 PS1, Line 1850: string master_addr = cluster_->master()->bound_rpc_addr().ToString(); : shared_ptr<KuduClient> client; : ASSERT_OK(KuduClientBuilder() : .add_master_server_addr(master_addr) : .Build(&client)); nit: move this down below the tool call, since it's not used until later? http://gerrit.cloudera.org:8080/#/c/10337/1/src/kudu/tools/tool_action_table.cc File src/kudu/tools/tool_action_table.cc: http://gerrit.cloudera.org:8080/#/c/10337/1/src/kudu/tools/tool_action_table.cc@121 PS1, Line 121: const string& master_addresses_str = FindOrDie(context.required_args, : kMasterAddressesArg); : vector<string> master_addresses = Split(master_addresses_str, ","); : const string& table_name = FindOrDie(context.required_args, kTableNameArg); : const string& new_table_name = FindOrDie(context.required_args, kNewTableNameArg); : : client::sp::shared_ptr<KuduClient> client; : RETURN_NOT_OK(KuduClientBuilder() : .master_server_addrs(master_addresses) : .Build(&client)); seems this is the same code as lines 108-116 above. Can we factor it out somehow? -- To view, visit http://gerrit.cloudera.org:8080/10337 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I49a8c352ded124eef99f341ab552961fc3dc1260 Gerrit-Change-Number: 10337 Gerrit-PatchSet: 1 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Tue, 08 May 2018 15:33:36 +0000 Gerrit-HasComments: Yes
