Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10340 )
Change subject: WIP KUDU-2359: allow startup with missing data dirs ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10340/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10340/1//COMMIT_MSG@10 PS1, Line 10: Note that this behavior is different than starting : up Kudu with extra data directories in `fs_data_dirs`, which is still : not supported unless running the update tool. Just to clarify, I think this patch makes it so that if I pass --fs-data-dirs=/a,/b,/c and it turns out /c is missing on disk, the server still starts up. However, if I pass --fs-data-dirs=/a,/b, the server fails to start, regardless of whether /c is missing or not. That persists until I run 'kudu fs update_data_dirs --fs-data-dirs=/a,/b". Is all this correct? If so, could you clarify this part of the commit message to say that this behavior is different than starting up Kudu with extra or with missing entries in `fs_data_dirs`? The first time I read this I thought that by not mentioning "missing entries", the patch was allowing for that kind of "allow startup with missing data dirs" too, which, as far as I can tell, isn't what KUDU-2359 was requesting. -- To view, visit http://gerrit.cloudera.org:8080/10340 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I61a71265c3cc34a7b72320149770a814ec7f8351 Gerrit-Change-Number: 10340 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Tue, 08 May 2018 18:33:49 +0000 Gerrit-HasComments: Yes
