Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10340 )
Change subject: KUDU-2359: allow startup with missing data dirs ...................................................................... Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/10340/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10340/2//COMMIT_MSG@12 PS2, Line 12: , etc. POSIX codes when reading : FS and block manager i > Nit: "reading fs and block manager instance files". Done http://gerrit.cloudera.org:8080/#/c/10340/2//COMMIT_MSG@21 PS2, Line 21: specifie > Nit: requested Done http://gerrit.cloudera.org:8080/#/c/10340/2/src/kudu/fs/block_manager_util.cc File src/kudu/fs/block_manager_util.cc: http://gerrit.cloudera.org:8080/#/c/10340/2/src/kudu/fs/block_manager_util.cc@52 PS2, Line 52: // Evaluates 'status_expr' and if it results in a disk-failure error, logs a > My comment in the commit message addresses this. Updated this comment with a note, not going into why NotFound errors shouldn't be lumped into IsDiskFailure, but at least explaining why IsNotFound is appropriate here. http://gerrit.cloudera.org:8080/#/c/10340/2/src/kudu/fs/data_dirs.h File src/kudu/fs/data_dirs.h: http://gerrit.cloudera.org:8080/#/c/10340/2/src/kudu/fs/data_dirs.h@423 PS2, Line 423: It also : // includes instance files that failed to load because they were missing or : // because of a disk failure; they are still considered "loaded" and a > Maybe reword: "It also includes instance files that failed to load because Done http://gerrit.cloudera.org:8080/#/c/10340/2/src/kudu/fs/data_dirs.cc File src/kudu/fs/data_dirs.cc: http://gerrit.cloudera.org:8080/#/c/10340/2/src/kudu/fs/data_dirs.cc@603 PS2, Line 603: Substitute("could not load $0", instance_filename)); > As implemented, this gives us a clear separation between missing directorie Done, made LoadInstances() return missing/failed/healthy instances together. -- To view, visit http://gerrit.cloudera.org:8080/10340 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I61a71265c3cc34a7b72320149770a814ec7f8351 Gerrit-Change-Number: 10340 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Wed, 23 May 2018 20:09:04 +0000 Gerrit-HasComments: Yes
