Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10352 )
Change subject: thirdparty: tweak clang compiler flags ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/10352/2/thirdparty/build-definitions.sh File thirdparty/build-definitions.sh: http://gerrit.cloudera.org:8080/#/c/10352/2/thirdparty/build-definitions.sh@311 PS2, Line 311: # in the install prefix. It will try to link against that version instead : # of the one being built. : rm -Rf $PREFIX/include/{llvm*,clang*} \ : $PREFIX/lib/lib{LLVM,LTO,clang}* \ : $PREFIX/lib/clang/ \ : $PREFIX/lib/cmake/{llvm,clang} > So it turns out this isn't actually necessary for TSAN builds. If you look I don't think your suggestion would fix the original issue, since CLANG_LDFLAGS can't be included in CMAKE_CXX_FLAGS. I tried to keep the latest revision as close as possible to this suggestion, other than that. -- To view, visit http://gerrit.cloudera.org:8080/10352 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ide4ddbff14d3745c6f2c2f9b14b00da790a6cec6 Gerrit-Change-Number: 10352 Gerrit-PatchSet: 3 Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Wed, 09 May 2018 21:38:24 +0000 Gerrit-HasComments: Yes
