Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10352 )
Change subject: thirdparty: tweak clang compiler flags ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/10352/3/thirdparty/build-definitions.sh File thirdparty/build-definitions.sh: http://gerrit.cloudera.org:8080/#/c/10352/3/thirdparty/build-definitions.sh@278 PS3, Line 278: # Depend on zlib from the thirdparty tree. It's an optional dependency for Can you add to this comment that we don't need to do this for TSAN because all TSAN dependencies are already configured to depend on PREFIX in order to get libc++abi? You can link to the relevant comment in build-thirdparty.sh: # libc++ (and its dependents) need to find libc++abi at link and run time. -- To view, visit http://gerrit.cloudera.org:8080/10352 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ide4ddbff14d3745c6f2c2f9b14b00da790a6cec6 Gerrit-Change-Number: 10352 Gerrit-PatchSet: 3 Gerrit-Owner: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Thu, 10 May 2018 01:36:08 +0000 Gerrit-HasComments: Yes
