Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10443 )
Change subject: KUDU-2444 TabletServerTest.TestTombstonedTabletOnWebUI is flaky ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/10443/1/src/kudu/tserver/tablet_server-test.cc File src/kudu/tserver/tablet_server-test.cc: http://gerrit.cloudera.org:8080/#/c/10443/1/src/kudu/tserver/tablet_server-test.cc@541 PS1, Line 541: mini_server_->Shutdown(); : ASSERT_OK(mini_server_->Restart()); : ASSERT_OK(mini_server_->WaitStarted()) > Okay. What do you think of my first suggestion: moving this into the test f Yup, good idea. It applies here and to another test in this file. The tablet copy itest that also had this problem doesn't use the same fixture, and it running vs an EMC, so I think retrying in the test is appropriate there. -- To view, visit http://gerrit.cloudera.org:8080/10443 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib8dc7acc4c39f9d9b067a52df4bd6732f545a8de Gerrit-Change-Number: 10443 Gerrit-PatchSet: 3 Gerrit-Owner: Will Berkeley <wdberke...@gmail.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-Comment-Date: Tue, 22 May 2018 18:05:16 +0000 Gerrit-HasComments: Yes
