Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10443 )
Change subject: KUDU-2444 TabletServerTest.TestTombstonedTabletOnWebUI is flaky ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/10443/4/src/kudu/tserver/tablet_server-test-base.cc File src/kudu/tserver/tablet_server-test-base.cc: http://gerrit.cloudera.org:8080/#/c/10443/4/src/kudu/tserver/tablet_server-test-base.cc@346 PS4, Line 346: void TabletServerTestBase::TombstoneTablet() { This isn't what I had in mind; sorry for not explaining well. I was thinking that since the test fixture is responsible for creating the tablet, it should also _wait for the tablet transition marker to be removed_ before handing control over to the test. Then the particular test that's flaky wouldn't need any changes (though the other one may still need an ASSERT_EVENTUALLY. -- To view, visit http://gerrit.cloudera.org:8080/10443 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib8dc7acc4c39f9d9b067a52df4bd6732f545a8de Gerrit-Change-Number: 10443 Gerrit-PatchSet: 4 Gerrit-Owner: Will Berkeley <wdberke...@gmail.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-Comment-Date: Tue, 22 May 2018 20:05:18 +0000 Gerrit-HasComments: Yes
