Andrew Wong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10340 )

Change subject: KUDU-2359: allow startup with missing data dirs
......................................................................


Patch Set 5:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/10340/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/10340/2//COMMIT_MSG@54
PS2, Line 54:    that previously triggered disk failure handling would trigger 
that
> Still open.
Done


http://gerrit.cloudera.org:8080/#/c/10340/2//COMMIT_MSG@58
PS2, Line 58: d treat the errors
            :    similarly, creating in-memory "unhealthy" instances. To open
> Nit: singular/plural confusion here
Done


http://gerrit.cloudera.org:8080/#/c/10340/5/src/kudu/fs/block_manager_util.cc
File src/kudu/fs/block_manager_util.cc:

http://gerrit.cloudera.org:8080/#/c/10340/5/src/kudu/fs/block_manager_util.cc@56
PS5, Line 56: PIMFs
> I don't think this acronym is used elsewhere in the code.
Done



--
To view, visit http://gerrit.cloudera.org:8080/10340
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I61a71265c3cc34a7b72320149770a814ec7f8351
Gerrit-Change-Number: 10340
Gerrit-PatchSet: 5
Gerrit-Owner: Andrew Wong <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Wed, 23 May 2018 22:28:25 +0000
Gerrit-HasComments: Yes

Reply via email to