Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10061 )
Change subject: [tools] ksck improvements [5/n]: Checks for experimental, unsafe, hidden flags ...................................................................... Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/10061/7/src/kudu/tools/ksck_remote-test.cc File src/kudu/tools/ksck_remote-test.cc: http://gerrit.cloudera.org:8080/#/c/10061/7/src/kudu/tools/ksck_remote-test.cc@216 PS7, Line 216: private: : client::KuduSchema schema_; : Random random_; : }; : : TEST_F(RemoteKsckTest, TestClusterOk) { : ASSERT_OK(ksck_->CheckMasterHealth()); > I thought not but actually the test will usually fail if this is replaced w Yep, sgtm. Was just curious since it would also hammer in the point that these other tests _aren't_ necessarily doing a full ksck run. http://gerrit.cloudera.org:8080/#/c/10061/7/src/kudu/tools/ksck_results.cc File src/kudu/tools/ksck_results.cc: http://gerrit.cloudera.org:8080/#/c/10061/7/src/kudu/tools/ksck_results.cc@149 PS7, Line 149: n > The block L144-146 guarantees that n > server.size() here. Hmm... maybe i'm missing something. Doesn't that block return in the `n >= server.size()` case, and mean that over here, we're guaranteed the opposite? `n < server.size()` -- To view, visit http://gerrit.cloudera.org:8080/10061 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idd6c179e5256b2f2bae2f7486c5e0365ef184706 Gerrit-Change-Number: 10061 Gerrit-PatchSet: 8 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Fri, 25 May 2018 22:22:45 +0000 Gerrit-HasComments: Yes
