Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/10061 )
Change subject: [tools] ksck improvements [5/n]: Checks for experimental, unsafe, hidden flags ...................................................................... Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/10061/5/src/kudu/tools/ksck.cc File src/kudu/tools/ksck.cc: http://gerrit.cloudera.org:8080/#/c/10061/5/src/kudu/tools/ksck.cc@369 PS5, Line 369: // Fetch the flags information. why isn't this part simply above the lock instead of moving the lock to a new block? http://gerrit.cloudera.org:8080/#/c/10061/5/src/kudu/tools/ksck_remote-test.cc File src/kudu/tools/ksck_remote-test.cc: http://gerrit.cloudera.org:8080/#/c/10061/5/src/kudu/tools/ksck_remote-test.cc@95 PS5, Line 95: FLAGS_safe_time_max_lag_ms = 60000; can we define a test flag instead? moving this flag to stable would break these tests http://gerrit.cloudera.org:8080/#/c/10061/5/src/kudu/tools/ksck_results.cc File src/kudu/tools/ksck_results.cc: http://gerrit.cloudera.org:8080/#/c/10061/5/src/kudu/tools/ksck_results.cc@138 PS5, Line 138: return JoinStrings(first_n, ", "); flags are usually defined the same way on each server, especially when a cluster management tool like Cloudera Manager is used, so we should check if all servers are affected and print something like "ALL" instead of listing them. -- To view, visit http://gerrit.cloudera.org:8080/10061 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idd6c179e5256b2f2bae2f7486c5e0365ef184706 Gerrit-Change-Number: 10061 Gerrit-PatchSet: 5 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Fri, 25 May 2018 15:57:20 +0000 Gerrit-HasComments: Yes
