Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9773 )
Change subject: KUDU-2353 (part 1): add a tool to parse stacks from diagnostics log ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/9773/2/src/kudu/tools/tool_action_diagnose.cc File src/kudu/tools/tool_action_diagnose.cc: http://gerrit.cloudera.org:8080/#/c/9773/2/src/kudu/tools/tool_action_diagnose.cc@188 PS2, Line 188: } else { : type_ = R > Well, LogParser won't be taking ownership of part of the stream; ParsedLine Done http://gerrit.cloudera.org:8080/#/c/9773/2/src/kudu/tools/tool_action_diagnose.cc@335 PS2, Line 335: ++group) { > Can you show me how you reached that conclusion? Not saying you're wrong; I There's discussion and reports of what people have tried here: https://stackoverflow.com/questions/17337602/how-to-get-error-message-when-ifstream-open-fails. The general conclusion being all error reporting appears to be somewhat implementation-dependent. Related questions report the same thing, and that the stream library was apparently designed before errors were discovered since there's no clear way to get at them. man 3 errno on Linux seems to promise all syscalls will set the value on error; I can't find a clear statement of something similar about macos but people report it works on SO. So mostly I'm going by what people say on SO. -- To view, visit http://gerrit.cloudera.org:8080/9773 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic5969cb3a54f691356e9cd3add150e717538a687 Gerrit-Change-Number: 9773 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Wed, 30 May 2018 08:17:38 +0000 Gerrit-HasComments: Yes
