Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9773 )
Change subject: KUDU-2353 (part 1): add a tool to parse stacks from diagnostics log ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/9773/4/src/kudu/tools/tool_action_diagnose.cc File src/kudu/tools/tool_action_diagnose.cc: http://gerrit.cloudera.org:8080/#/c/9773/4/src/kudu/tools/tool_action_diagnose.cc@147 PS4, Line 147: const string kUnknown = "<unknown>"; > It was a little confusing to me that kUnknown is both a const string privat Done http://gerrit.cloudera.org:8080/#/c/9773/4/src/kudu/tools/tool_action_diagnose.cc@253 PS4, Line 253: lf > nit: why lf instead of pl? Done -- To view, visit http://gerrit.cloudera.org:8080/9773 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic5969cb3a54f691356e9cd3add150e717538a687 Gerrit-Change-Number: 9773 Gerrit-PatchSet: 4 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Fri, 01 Jun 2018 15:22:02 +0000 Gerrit-HasComments: Yes
