Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10542 )
Change subject: [tools] KUDU-2413 Configurable # of reactors in loadgen ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/10542/1/src/kudu/tools/tool_action_perf.cc File src/kudu/tools/tool_action_perf.cc: http://gerrit.cloudera.org:8080/#/c/10542/1/src/kudu/tools/tool_action_perf.cc@257 PS1, Line 257: thread threads http://gerrit.cloudera.org:8080/#/c/10542/1/src/kudu/tools/tool_action_perf.cc@563 PS1, Line 563: num_reactors Would it make sense to use a "smart default" that is set based on the number of worker threads (--num_threads)? I'm not sure what proportion they should be in...maybe Todd has some idea? http://gerrit.cloudera.org:8080/#/c/10542/1/src/kudu/tools/tool_action_perf.cc@661 PS1, Line 661: .AddOptionalParameter For tools, new flags also need to be registered down here. -- To view, visit http://gerrit.cloudera.org:8080/10542 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8f02e6ac153ff58c2d3a89a9966ea6fe721db06e Gerrit-Change-Number: 10542 Gerrit-PatchSet: 1 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Wed, 30 May 2018 15:44:48 +0000 Gerrit-HasComments: Yes
