Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/10542 )
Change subject: [tools] KUDU-2413 Configurable # of reactors in loadgen ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/10542/1/src/kudu/tools/tool_action_perf.cc File src/kudu/tools/tool_action_perf.cc: http://gerrit.cloudera.org:8080/#/c/10542/1/src/kudu/tools/tool_action_perf.cc@257 PS1, Line 257: int (e > threads Done http://gerrit.cloudera.org:8080/#/c/10542/1/src/kudu/tools/tool_action_perf.cc@563 PS1, Line 563: eactors > 0) > Would it make sense to use a "smart default" that is set based on the numbe not sure, using a smart default is a good idea, but the calculation should be on the Messenger side itself, which at this point is 4 as well. anyway, if this is a smart default, it should be decided there instead of here, although I'm not sure how to document that, As I don't think I can use std::optional here, I could go with 0 or -1 and it feels weird to say "default (0) means it remains unset and it's decided somewhere else" or something http://gerrit.cloudera.org:8080/#/c/10542/1/src/kudu/tools/tool_action_perf.cc@661 PS1, Line 661: "Addresses are in > For tools, new flags also need to be registered down here. thanks, I should've tested it... -- To view, visit http://gerrit.cloudera.org:8080/10542 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8f02e6ac153ff58c2d3a89a9966ea6fe721db06e Gerrit-Change-Number: 10542 Gerrit-PatchSet: 2 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Wed, 30 May 2018 16:25:13 +0000 Gerrit-HasComments: Yes
