Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10224 )
Change subject: build: improve parse_test_failure script ...................................................................... Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/10224/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10224/2//COMMIT_MSG@7 PS2, Line 7: build: improve parse_test_failure script I just filed KUDU-2460 for this; could you link to it? http://gerrit.cloudera.org:8080/#/c/10224/2/build-support/parse_test_failure.py File build-support/parse_test_failure.py: http://gerrit.cloudera.org:8080/#/c/10224/2/build-support/parse_test_failure.py@67 PS2, Line 67: glog_fatals: if true, look for lines that look like glog check failures. : These don't always represent test failures. Neither of the LogParser instantiations here customize this. Can it be dropped? http://gerrit.cloudera.org:8080/#/c/10224/2/build-support/parse_test_failure.py@99 PS2, Line 99: self._start_test("General.OutsideOfAnyTestCase") Can we try to deduce "General" from the log text? It'd be nice to scope TSAN warnings and the like to the particular test suite where they were reported. That'd also benefit the flaky test tracker. http://gerrit.cloudera.org:8080/#/c/10224/2/build-support/parse_test_failure.py@114 PS2, Line 114: def _fast_re(substr, regexp, line): Doc? I mean, what it does is obvious, but why is it done this way? http://gerrit.cloudera.org:8080/#/c/10224/2/build-support/parse_test_failure.py@148 PS2, Line 148: asan_lines = self._remove_glog_lines(self._consume_rest(line_iter)) _consume_rest is appropriate here because ASAN failures should have killed the test process? Can you doc that? -- To view, visit http://gerrit.cloudera.org:8080/10224 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idbc5ce7f7aa522c2c581afe33d4e40719ed7474a Gerrit-Change-Number: 10224 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Comment-Date: Thu, 31 May 2018 00:02:23 +0000 Gerrit-HasComments: Yes
