Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10224 )
Change subject: KUDU-2460. build: improve parse_test_failure script ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/10224/2/build-support/parse_test_failure.py File build-support/parse_test_failure.py: http://gerrit.cloudera.org:8080/#/c/10224/2/build-support/parse_test_failure.py@67 PS2, Line 67: : @staticmethod > Neither of the LogParser instantiations here customize this. Can it be drop Done http://gerrit.cloudera.org:8080/#/c/10224/2/build-support/parse_test_failure.py@99 PS2, Line 99: self._cur_test.errors.append(error) > Can we try to deduce "General" from the log text? It'd be nice to scope TSA I'll add a TODO here if that's OK. It won't benefit the flaky tracker because the flaky tracker just uses the top-level executable name as a key and doesn't look at the XML. http://gerrit.cloudera.org:8080/#/c/10224/2/build-support/parse_test_failure.py@114 PS2, Line 114: This provides a big speed-up since substring searches execute much more > Doc? I mean, what it does is obvious, but why is it done this way? Done http://gerrit.cloudera.org:8080/#/c/10224/2/build-support/parse_test_failure.py@148 PS2, Line 148: if m: > _consume_rest is appropriate here because ASAN failures should have killed Done -- To view, visit http://gerrit.cloudera.org:8080/10224 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idbc5ce7f7aa522c2c581afe33d4e40719ed7474a Gerrit-Change-Number: 10224 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Mon, 06 Aug 2018 18:52:56 +0000 Gerrit-HasComments: Yes
