Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10375 )
Change subject: WIP: Kudu Backup/Restore Spark Jobs ...................................................................... Patch Set 10: (2 comments) Did another high level review. Looking good. Just a couple questions. http://gerrit.cloudera.org:8080/#/c/10375/10/java/kudu-backup/src/main/protobuf/backup.proto File java/kudu-backup/src/main/protobuf/backup.proto: http://gerrit.cloudera.org:8080/#/c/10375/10/java/kudu-backup/src/main/protobuf/backup.proto@36 PS10, Line 36: message ColumnMetadataPB { Since we're not using the internal PB, any ideas on how we can guarantee that we don't forget to add a field to the backup protobuf when we add a new field to the application PB? http://gerrit.cloudera.org:8080/#/c/10375/10/java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduRestoreOptions.scala File java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduRestoreOptions.scala: http://gerrit.cloudera.org:8080/#/c/10375/10/java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduRestoreOptions.scala@37 PS10, Line 37: opt[Boolean]("createTables") nit: maybe this should be required with a fallback (default value)? -- To view, visit http://gerrit.cloudera.org:8080/10375 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If02183a2f833ffa0225eb7b0a35fc7531109e6f7 Gerrit-Change-Number: 10375 Gerrit-PatchSet: 10 Gerrit-Owner: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Thu, 31 May 2018 22:38:16 +0000 Gerrit-HasComments: Yes
