Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10375 )
Change subject: WIP: Kudu Backup/Restore Spark Jobs ...................................................................... Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/10375/10/java/kudu-backup/src/main/protobuf/backup.proto File java/kudu-backup/src/main/protobuf/backup.proto: http://gerrit.cloudera.org:8080/#/c/10375/10/java/kudu-backup/src/main/protobuf/backup.proto@36 PS10, Line 36: message ColumnMetadataPB { > Since we're not using the internal PB, any ideas on how we can guarantee th This PB doesn't need to be synchronized with the internal ColumnSchemaPB; it only needs to be synchronized with whatever client APIs are used to backup tables (Grant's new partition fetching APIs) and restore tables (Create Table). And since those are client APIs and not internal PBs, they're more likely to change in backward-compatible ways, so the coupling to this PB could remain loose. -- To view, visit http://gerrit.cloudera.org:8080/10375 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If02183a2f833ffa0225eb7b0a35fc7531109e6f7 Gerrit-Change-Number: 10375 Gerrit-PatchSet: 10 Gerrit-Owner: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Thu, 31 May 2018 23:06:44 +0000 Gerrit-HasComments: Yes
