Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9773 )
Change subject: KUDU-2353 (part 1): add a tool to parse stacks from diagnostics log ...................................................................... Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/9773/8/src/kudu/tools/diagnostics_log_parser-test.cc File src/kudu/tools/diagnostics_log_parser-test.cc: PS8: Much of the parsing code returns InvalidArgument on failure, so for negative test cases, can you test the stringified Status to make sure the InvalidArgument error you got is the one you expected to get? -- To view, visit http://gerrit.cloudera.org:8080/9773 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic5969cb3a54f691356e9cd3add150e717538a687 Gerrit-Change-Number: 9773 Gerrit-PatchSet: 8 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Fri, 01 Jun 2018 17:33:19 +0000 Gerrit-HasComments: Yes
