Will Berkeley has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10548 )

Change subject: KUDU-2242 Wait for NTP synchronization on startup
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/10548/4/src/kudu/clock/system_ntp.cc
File src/kudu/clock/system_ntp.cc:

http://gerrit.cloudera.org:8080/#/c/10548/4/src/kudu/clock/system_ntp.cc@130
PS4, Line 130: 1
> Should this be configurable as well?
I don't think so. This is the shortest period which gives us the least wait 
once synchronization occurs. Each check is quick (just querying the local ntpd 
for a tiny bit of info or failing to connect ) so I don't thing allowing people 
to raise it would be useful.



--
To view, visit http://gerrit.cloudera.org:8080/10548
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6082c5d35ed0d230d91c61734e7b5a351e50933b
Gerrit-Change-Number: 10548
Gerrit-PatchSet: 4
Gerrit-Owner: Will Berkeley <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Hao Hao <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <[email protected]>
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Will Berkeley <[email protected]>
Gerrit-Comment-Date: Fri, 01 Jun 2018 20:31:09 +0000
Gerrit-HasComments: Yes

Reply via email to