Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10548 )
Change subject: KUDU-2242 Wait for NTP synchronization on startup ...................................................................... Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/10548/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10548/3//COMMIT_MSG@25 PS3, Line 25: existed > exited? Done http://gerrit.cloudera.org:8080/#/c/10548/3/src/kudu/clock/system_ntp.cc File src/kudu/clock/system_ntp.cc: http://gerrit.cloudera.org:8080/#/c/10548/3/src/kudu/clock/system_ntp.cc@113 PS3, Line 113: WaitForNtp > BTW, how do you know whether chronyd or ntpd is used to synchronize the clo We don't. We try ntpd first, and chrony afterwards just to be nice, since we say we only test with ntpd So we rely on the packaging/people not installing both at once. http://gerrit.cloudera.org:8080/#/c/10548/3/src/kudu/clock/system_ntp.cc@122 PS3, Line 122: . > nit: drop? Done http://gerrit.cloudera.org:8080/#/c/10548/3/src/kudu/clock/system_ntp.cc@133 PS3, Line 133: "/sbin", "/usr/sbin" > Doesn't FindExecutable() fall back to a PATH-based search if the binary isn It does. See the function comment in kudu/util/path_util.h. http://gerrit.cloudera.org:8080/#/c/10548/3/src/kudu/clock/system_ntp.cc@185 PS3, Line 185: s = WaitForNtp(); : if (s.ok()) { : s = CallAdjTime(&timex); : } > nit: consider using Status::AndThen() Done -- To view, visit http://gerrit.cloudera.org:8080/10548 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6082c5d35ed0d230d91c61734e7b5a351e50933b Gerrit-Change-Number: 10548 Gerrit-PatchSet: 3 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Fri, 01 Jun 2018 19:16:49 +0000 Gerrit-HasComments: Yes
