Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10540 )
Change subject: [kudu CLI] more integration tests for rebalancer ...................................................................... Patch Set 7: (10 comments) Just some nits I forgot to post earlier...otherwise looks good. http://gerrit.cloudera.org:8080/#/c/10540/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10540/5//COMMIT_MSG@7 PS5, Line 7: kudu CLI [tools] is standard, I think. http://gerrit.cloudera.org:8080/#/c/10540/5/src/kudu/tools/kudu-admin-test.cc File src/kudu/tools/kudu-admin-test.cc: http://gerrit.cloudera.org:8080/#/c/10540/5/src/kudu/tools/kudu-admin-test.cc@1374 PS5, Line 1374: useful http://gerrit.cloudera.org:8080/#/c/10540/5/src/kudu/tools/kudu-admin-test.cc@1522 PS5, Line 1522: Why this instead of ASSERT_OK? You're consistent about it in these tests. http://gerrit.cloudera.org:8080/#/c/10540/5/src/kudu/tools/kudu-admin-test.cc@1533 PS5, Line 1533: Should this also be parametrized on 3-4-3? http://gerrit.cloudera.org:8080/#/c/10540/5/src/kudu/tools/kudu-admin-test.cc@1594 PS5, Line 1594: dynamic http://gerrit.cloudera.org:8080/#/c/10540/5/src/kudu/tools/kudu-admin-test.cc@1595 PS5, Line 1595: dynamic http://gerrit.cloudera.org:8080/#/c/10540/5/src/kudu/tools/kudu-admin-test.cc@1711 PS5, Line 1711: get stuck http://gerrit.cloudera.org:8080/#/c/10540/5/src/kudu/tools/kudu-admin-test.cc@1712 PS5, Line 1712: ) a http://gerrit.cloudera.org:8080/#/c/10540/5/src/kudu/tools/kudu-admin-test.cc@1765 PS5, Line 1765: ing err; But we might expect a bad status in s? http://gerrit.cloudera.org:8080/#/c/10540/7/src/kudu/tools/kudu-admin-test.cc File src/kudu/tools/kudu-admin-test.cc: http://gerrit.cloudera.org:8080/#/c/10540/7/src/kudu/tools/kudu-admin-test.cc@1568 PS7, Line 1568: // The idea is to wait until the rebalancer starts. Looks like this belongs above L1565. -- To view, visit http://gerrit.cloudera.org:8080/10540 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I78b3dcea71ed303f6ecd199604b2385796d05da8 Gerrit-Change-Number: 10540 Gerrit-PatchSet: 7 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Tue, 05 Jun 2018 18:50:36 +0000 Gerrit-HasComments: Yes
