Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10540 )
Change subject: [tools] more integration tests for rebalancer ...................................................................... Patch Set 8: (9 comments) http://gerrit.cloudera.org:8080/#/c/10540/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10540/5//COMMIT_MSG@7 PS5, Line 7: kudu CLI > [tools] is standard, I think. Done http://gerrit.cloudera.org:8080/#/c/10540/5/src/kudu/tools/kudu-admin-test.cc File src/kudu/tools/kudu-admin-test.cc: http://gerrit.cloudera.org:8080/#/c/10540/5/src/kudu/tools/kudu-admin-test.cc@1374 PS5, Line 1374: > useful Done http://gerrit.cloudera.org:8080/#/c/10540/5/src/kudu/tools/kudu-admin-test.cc@1522 PS5, Line 1522: > Why this instead of ASSERT_OK? You're consistent about it in these tests. Ah, that's because ASSERT_OK() does not do the following: ASSERT_OK(s) << s.ToString() << ":" << err; http://gerrit.cloudera.org:8080/#/c/10540/5/src/kudu/tools/kudu-admin-test.cc@1533 PS5, Line 1533: RunKuduTool(tool_args, &out, &err); > Should this also be parametrized on 3-4-3? Done http://gerrit.cloudera.org:8080/#/c/10540/5/src/kudu/tools/kudu-admin-test.cc@1594 PS5, Line 1594: > dynamic Done http://gerrit.cloudera.org:8080/#/c/10540/5/src/kudu/tools/kudu-admin-test.cc@1595 PS5, Line 1595: ete_tab > dynamic Done http://gerrit.cloudera.org:8080/#/c/10540/5/src/kudu/tools/kudu-admin-test.cc@1711 PS5, Line 1711: > get stuck Done http://gerrit.cloudera.org:8080/#/c/10540/5/src/kudu/tools/kudu-admin-test.cc@1712 PS5, Line 1712: m > a Done http://gerrit.cloudera.org:8080/#/c/10540/5/src/kudu/tools/kudu-admin-test.cc@1765 PS5, Line 1765: > But we might expect a bad status in s? Yep, it can be like that -- e.g., if due to some conditions the rebalancer didn't able to make progress for too long (there is --max_staleness_interval_sec for that). I added a comment on that. -- To view, visit http://gerrit.cloudera.org:8080/10540 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I78b3dcea71ed303f6ecd199604b2385796d05da8 Gerrit-Change-Number: 10540 Gerrit-PatchSet: 8 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Wed, 06 Jun 2018 08:21:15 +0000 Gerrit-HasComments: Yes
