Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10581 )
Change subject: KUDU-2191: Add a method to decide the scope of AlterTable ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/10581/3/src/kudu/master/master.proto File src/kudu/master/master.proto: http://gerrit.cloudera.org:8080/#/c/10581/3/src/kudu/master/master.proto@568 PS3, Line 568: // Whether to alter the table in Kudu as well as in the Hive Metastore, > Done Sorry I'm late to this, but I don't agree with this change. 'NO_HMS' isn't a system type, it's the lack of a type. 'ExternalSystem' is too general, as well. I'd prefer // Whether to apply the alteration to external catalogs, such as the Hive Metastore, // which the Kudu master has been configured to integrate with. optional bool alter_external_catalogs = 5 [default = true]; As far as enum vs bool, I don't think the enum is any more future proof than a boolean. It's impossible to know if/when we integrate with another external catalog system whether the enum will be useful vs just a boolean. I do see value in making it slightly less HMS specific, though. -- To view, visit http://gerrit.cloudera.org:8080/10581 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I703f12b95bb7ca2d65455f0f0602520332b3c678 Gerrit-Change-Number: 10581 Gerrit-PatchSet: 5 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Mon, 11 Jun 2018 21:11:25 +0000 Gerrit-HasComments: Yes
