Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/10581 )
Change subject: KUDU-2191: Add a method to decide the scope of AlterTable ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/10581/5/src/kudu/client/client.cc File src/kudu/client/client.cc: http://gerrit.cloudera.org:8080/#/c/10581/5/src/kudu/client/client.cc@1144 PS5, Line 1144: bool alter_external_catalogs) { > This doesn't do the right thing if you call system(true) followed by system Done http://gerrit.cloudera.org:8080/#/c/10581/3/src/kudu/master/master.proto File src/kudu/master/master.proto: http://gerrit.cloudera.org:8080/#/c/10581/3/src/kudu/master/master.proto@568 PS3, Line 568: // Whether to apply the alteration to external catalogs, such as the Hive Metastore, > Sorry I'm late to this, but I don't agree with this change. 'NO_HMS' isn't Done -- To view, visit http://gerrit.cloudera.org:8080/10581 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I703f12b95bb7ca2d65455f0f0602520332b3c678 Gerrit-Change-Number: 10581 Gerrit-PatchSet: 6 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Mon, 11 Jun 2018 22:54:09 +0000 Gerrit-HasComments: Yes
