Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10734 )
Change subject: KUDU-2314 Fix printing empty wal & metadata dirs ...................................................................... Patch Set 1: Verified+1 (2 comments) Test failure seems unrelated http://gerrit.cloudera.org:8080/#/c/10734/1/src/kudu/fs/fs_manager-test.cc File src/kudu/fs/fs_manager-test.cc: http://gerrit.cloudera.org:8080/#/c/10734/1/src/kudu/fs/fs_manager-test.cc@1002 PS1, Line 1002: TestOpenReport > hmm..maybe this is not a descrptive name? Perhaps TestAncillaryDirsReported or something? http://gerrit.cloudera.org:8080/#/c/10734/1/src/kudu/fs/fs_manager-test.cc@1011 PS1, Line 1011: "metadata directory: " + wal_path How about a test that uses a separate WAL and metadata directory? That way this wouldn't break if this default behavior ever changes. -- To view, visit http://gerrit.cloudera.org:8080/10734 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8055b09f46d50b13a53bc53b28795c2bc4338d33 Gerrit-Change-Number: 10734 Gerrit-PatchSet: 1 Gerrit-Owner: Fengling Wang <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Fengling Wang <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Mon, 18 Jun 2018 17:07:37 +0000 Gerrit-HasComments: Yes
