Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10734 )
Change subject: KUDU-2314 Fix printing empty wal & metadata dirs ...................................................................... Patch Set 2: Code-Review+1 (3 comments) Looks good, just a few nits http://gerrit.cloudera.org:8080/#/c/10734/2/src/kudu/fs/fs_manager-test.cc File src/kudu/fs/fs_manager-test.cc: http://gerrit.cloudera.org:8080/#/c/10734/2/src/kudu/fs/fs_manager-test.cc@1003 PS2, Line 1003: fs::FsReport report; nit: maybe move this down by L1009 or 1010 where we actually use it? http://gerrit.cloudera.org:8080/#/c/10734/2/src/kudu/fs/fs_manager-test.cc@1007 PS2, Line 1007: asdf nit: maybe "metadata" for consistency? :) http://gerrit.cloudera.org:8080/#/c/10734/2/src/kudu/fs/fs_manager-test.cc@1008 PS2, Line 1008: opts nit: std::move(opts) -- To view, visit http://gerrit.cloudera.org:8080/10734 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8055b09f46d50b13a53bc53b28795c2bc4338d33 Gerrit-Change-Number: 10734 Gerrit-PatchSet: 2 Gerrit-Owner: Fengling Wang <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Fengling Wang <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Mon, 18 Jun 2018 21:54:48 +0000 Gerrit-HasComments: Yes
