Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10787 )
Change subject: Add a simple metric for cluster skew ...................................................................... Patch Set 2: (9 comments) http://gerrit.cloudera.org:8080/#/c/10787/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10787/2//COMMIT_MSG@31 PS2, Line 31: theshold threshold http://gerrit.cloudera.org:8080/#/c/10787/2//COMMIT_MSG@31 PS2, Line 31: - nit: add space or replace with a colon? http://gerrit.cloudera.org:8080/#/c/10787/2//COMMIT_MSG@33 PS2, Line 33: external force like unbalanced re-replication or the addition of a tablet nit: it would be nice to have a line with 72 chars or less of length for the commit message. http://gerrit.cloudera.org:8080/#/c/10787/2/src/kudu/master/ts_manager.cc File src/kudu/master/ts_manager.cc: http://gerrit.cloudera.org:8080/#/c/10787/2/src/kudu/master/ts_manager.cc@36 PS2, Line 36: cluster_skew Nit: would it make sense to include 'replica' or 'tablet' in the name of this metric (e.g. 'tablet_replicas_cluster_skew')? Or it already has some implicit namespacing? http://gerrit.cloudera.org:8080/#/c/10787/2/src/kudu/master/ts_manager.cc@145 PS2, Line 145: int& nit: why a reference, not just a copy of an integer value? http://gerrit.cloudera.org:8080/#/c/10787/2/src/kudu/scripts/max_skew_estimate.py File src/kudu/scripts/max_skew_estimate.py: http://gerrit.cloudera.org:8080/#/c/10787/2/src/kudu/scripts/max_skew_estimate.py@20 PS2, Line 20: This The http://gerrit.cloudera.org:8080/#/c/10787/2/src/kudu/scripts/max_skew_estimate.py@20 PS2, Line 20: aximum maximum http://gerrit.cloudera.org:8080/#/c/10787/2/src/kudu/scripts/max_skew_estimate.py@21 PS2, Line 21: nit: extra space http://gerrit.cloudera.org:8080/#/c/10787/2/src/kudu/scripts/max_skew_estimate.py@22 PS2, Line 22: is drop -- To view, visit http://gerrit.cloudera.org:8080/10787 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I107256de604998cbf9206a8fccb3a43de86f81a8 Gerrit-Change-Number: 10787 Gerrit-PatchSet: 2 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Fri, 22 Jun 2018 20:19:31 +0000 Gerrit-HasComments: Yes
