Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10787 )
Change subject: Add a simple metric for cluster skew ...................................................................... Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/10787/3/src/kudu/scripts/max_skew_estimate.py File src/kudu/scripts/max_skew_estimate.py: http://gerrit.cloudera.org:8080/#/c/10787/3/src/kudu/scripts/max_skew_estimate.py@31 PS3, Line 31: xrange Nit for here and below, but I think it's just a general comment that doesn't need to be addressed in this version of the patch: it seems in python3 xrange deprecated (and range does what xrange did in python2). If there are no memory issues with that code, maybe it's worth to use range() in future since one day it could help switching to python3. -- To view, visit http://gerrit.cloudera.org:8080/10787 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I107256de604998cbf9206a8fccb3a43de86f81a8 Gerrit-Change-Number: 10787 Gerrit-PatchSet: 3 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Wed, 27 Jun 2018 17:54:34 +0000 Gerrit-HasComments: Yes
