Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10809 )
Change subject: [python] : Add Pandas Support to Scanner ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/10809/4/build-support/jenkins/build-and-test.sh File build-support/jenkins/build-and-test.sh: http://gerrit.cloudera.org:8080/#/c/10809/4/build-support/jenkins/build-and-test.sh@454 PS4, Line 454: pip install pandas I think it would be more intuitive/maintainable to build this into the python code itself somehow. Perhaps into the setup.py like suggested here: https://stackoverflow.com/a/15422703 or perhaps a test-requirements.txt file? so we can run `pip install -r test-requirements.txt` Whatever approach is the most python standard I suppose. -- To view, visit http://gerrit.cloudera.org:8080/10809 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I90fab5c0c42448bcc17ea22be37420c6ef2f4915 Gerrit-Change-Number: 10809 Gerrit-PatchSet: 4 Gerrit-Owner: Jordan Birdsell <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Mon, 25 Jun 2018 17:33:51 +0000 Gerrit-HasComments: Yes
