David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/10809 )
Change subject: [python] : Add Pandas Support to Scanner ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/10809/4/build-support/jenkins/build-and-test.sh File build-support/jenkins/build-and-test.sh: http://gerrit.cloudera.org:8080/#/c/10809/4/build-support/jenkins/build-and-test.sh@454 PS4, Line 454: pip install pandas should we move our dependencies to the setup.py and have pandas as a test or optional dependency? http://gerrit.cloudera.org:8080/#/c/10809/4/python/kudu/client.pyx File python/kudu/client.pyx: http://gerrit.cloudera.org:8080/#/c/10809/4/python/kudu/client.pyx@2004 PS4, Line 2004: for col, dtype in types.items(): : df[col] = df[col].astype(dtype, copy=False) is this just a metadata change or does it actually change the data? -- To view, visit http://gerrit.cloudera.org:8080/10809 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I90fab5c0c42448bcc17ea22be37420c6ef2f4915 Gerrit-Change-Number: 10809 Gerrit-PatchSet: 4 Gerrit-Owner: Jordan Birdsell <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Mon, 25 Jun 2018 17:36:14 +0000 Gerrit-HasComments: Yes
