David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/10674 )
Change subject: KUDU-2441 - [python] Enable configuration of mutation buffer ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/10674/4/python/kudu/client.pyx File python/kudu/client.pyx: http://gerrit.cloudera.org:8080/#/c/10674/4/python/kudu/client.pyx@541 PS4, Line 541: Watermark level as percentage of the mutation buffer size. what does this watermark do, i.e. what happens when we go ober the waterman? http://gerrit.cloudera.org:8080/#/c/10674/4/python/kudu/client.pyx@544 PS4, Line 544: spurious tab http://gerrit.cloudera.org:8080/#/c/10674/4/python/kudu/tests/test_client.py File python/kudu/tests/test_client.py: http://gerrit.cloudera.org:8080/#/c/10674/4/python/kudu/tests/test_client.py@259 PS4, Line 259: def test_session_mutation_buffer_settings(self): : self.client.new_session(flush_mode=kudu.FLUSH_AUTO_BACKGROUND, : mutation_buffer_sz= 10*1024*1024, : mutation_buffer_watermark=0.5, : mutation_buffer_flush_interval=2000, : mutation_buffer_max_num=3) : : session = self.client.new_session(flush_mode=kudu.FLUSH_AUTO_BACKGROUND) : session.set_mutation_buffer_space(10*1024*1024) : session.set_mutation_buffer_flush_watermark(0.5) : session.set_mutation_buffer_flush_interval(2000) : session.set_mutation_buffer_max_num(3) hum thsi is only testing the happy cases maybe throw in a error case or two? -- To view, visit http://gerrit.cloudera.org:8080/10674 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I52ac48e7dddc31e666a95ace4c7672da51d80b11 Gerrit-Change-Number: 10674 Gerrit-PatchSet: 4 Gerrit-Owner: Jordan Birdsell <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Mon, 25 Jun 2018 17:46:32 +0000 Gerrit-HasComments: Yes
