Jordan Birdsell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10674 )
Change subject: [python] KUDU-2441: Enable configuration of mutation buffer ...................................................................... Patch Set 5: (11 comments) http://gerrit.cloudera.org:8080/#/c/10674/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10674/4//COMMIT_MSG@7 PS4, Line 7: [python] KUDU-2441: > nit: Could you order like "[<topic area>] KUDU-XXXX"? Done http://gerrit.cloudera.org:8080/#/c/10674/4//COMMIT_MSG@11 PS4, Line 11: respect. > respect Done http://gerrit.cloudera.org:8080/#/c/10674/4/python/kudu/client.pyx File python/kudu/client.pyx: http://gerrit.cloudera.org:8080/#/c/10674/4/python/kudu/client.pyx@528 PS4, Line 528: **kwargs): : """ : Create a new KuduSession for applying wr > I'm not sure what's idiomatic in Python, and I think it could reasonably di changed this to use kwargs. http://gerrit.cloudera.org:8080/#/c/10674/4/python/kudu/client.pyx@540 PS4, Line 540: rigger a flush in AUTO_FLUSH_BACKGROUND mode. > nit: "Size in bytes of the ..." and remove the parenthetical. Done http://gerrit.cloudera.org:8080/#/c/10674/4/python/kudu/client.pyx@541 PS4, Line 541: al : The duration of the interval for the time-based > what does this watermark do, i.e. what happens when we go ober the waterman added more clarity http://gerrit.cloudera.org:8080/#/c/10674/4/python/kudu/client.pyx@542 PS4, Line 542: some cases, while running in AUTO_FLUSH_BACKGROUND : mode, the size of the muta > This means that a flush will happen at least once in every interval of time added more detailed description http://gerrit.cloudera.org:8080/#/c/10674/4/python/kudu/client.pyx@544 PS4, Line 544: e > spurious tab Done http://gerrit.cloudera.org:8080/#/c/10674/4/python/kudu/client.pyx@1272 PS4, Line 1272: , > nit: Add a colon here and for the other flush modes. Done http://gerrit.cloudera.org:8080/#/c/10674/4/python/kudu/client.pyx@1295 PS4, Line 1295: > 50% of the buffer space? Done http://gerrit.cloudera.org:8080/#/c/10674/4/python/kudu/client.pyx@1295 PS4, Line 1295: > set to Done http://gerrit.cloudera.org:8080/#/c/10674/4/python/kudu/tests/test_client.py File python/kudu/tests/test_client.py: http://gerrit.cloudera.org:8080/#/c/10674/4/python/kudu/tests/test_client.py@259 PS4, Line 259: def test_session_mutation_buffer_settings(self): : self.client.new_session(flush_mode=kudu.FLUSH_AUTO_BACKGROUND, : mutation_buffer_sz= 10*1024*1024, : mutation_buffer_watermark=0.5, : mutation_buffer_flush_interval=2000, : mutation_buffer_max_num=3) : : session = self.client.new_session(flush_mode=kudu.FLUSH_AUTO_BACKGROUND) : session.set_mutation_buffer_space(10*1024*1024) : session.set_mutation_buffer_flush_watermark(0.5) : session.set_mutation_buffer_flush_interval(2000) : session.set_mutation_buffer_max_num(3) > hum thsi is only testing the happy cases maybe throw in a error case or two I added a test case for this, there wasnt much to test here since most invalid uses are handled safely but I added some invalid values cases. -- To view, visit http://gerrit.cloudera.org:8080/10674 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I52ac48e7dddc31e666a95ace4c7672da51d80b11 Gerrit-Change-Number: 10674 Gerrit-PatchSet: 5 Gerrit-Owner: Jordan Birdsell <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Jordan Birdsell <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Tue, 26 Jun 2018 18:48:38 +0000 Gerrit-HasComments: Yes
